Jerry/bird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fixes race condition leading to memory corruption and crash.

Browse source 
When protocol started, feeding was scheduled. If protocol
got down before feeding was executed, then function
responsible for connecting protocol to kernel routing
tables was called after the function responsible for
disconnecting, then resource pool of protocol was freed,
but freed linked list structures remains in the list.
This commit is contained in:
Ondrej Zajicek 2008-11-22 01:12:22 +01:00
parent 35f983f889
commit fbde6c3908
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
nest/proto.c
View file

@ -521,9 +521,10 @@ proto_feed_more(void *P)
{ {
struct proto *p = P; struct proto *p = P;
DBG("Feeding protocol %s continued\n", p->name);
if (p->core_state != FS_FEEDING) if (p->core_state != FS_FEEDING)
return; return;
DBG("Feeding protocol %s continued\n", p->name);
if (rt_feed_baby(p)) if (rt_feed_baby(p))
{ {
p->core_state = FS_HAPPY; p->core_state = FS_HAPPY;
@ -542,6 +543,9 @@ proto_feed(void *P)
{ {
struct proto *p = P; struct proto *p = P;
if (p->core_state != FS_FEEDING)
return;
DBG("Feeding protocol %s\n", p->name); DBG("Feeding protocol %s\n", p->name);
proto_add_announce_hook(p, p->table); proto_add_announce_hook(p, p->table);
if_feed_baby(p); if_feed_baby(p);