From 3d0ea3a7c3e3b14bd0b9602d6b14518c907d8789 Mon Sep 17 00:00:00 2001 From: Pavel Machek Date: Fri, 7 Apr 2000 09:02:17 +0000 Subject: [PATCH] Fix of comment. --- proto/rip/rip.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/proto/rip/rip.c b/proto/rip/rip.c index ad7b17fe..084ea99e 100644 --- a/proto/rip/rip.c +++ b/proto/rip/rip.c @@ -23,6 +23,20 @@ FIXME: (nonurgent) allow bigger frequencies than 1 regular update in 6 seconds (?) FIXME: propagation of metric=infinity into main routing table may or may not be good idea. + FIXME: mj wants us to be able to format attributes: + + Each protocol can now register its own attribute class (protocol->attr_class, + set to EAP_xxx) and also a callback for naming and formatting of attributes. + The callback can return one of the following results: + + GA_UNKNOWN Attribute not recognized. + GA_NAME Attribute name recognized and put to the buffer, + generic code should format the value. + GA_FULL Both attribute name and value put to the buffer. + + Please update protocols generating dynamic attributes to provide + the attr_class and formatting hook. + */ #define LOCAL_DEBUG @@ -710,9 +724,7 @@ rip_rt_notify(struct proto *p, struct network *net, struct rte *new, struct rte if (new->attrs->proto == p) e->whotoldme = new->attrs->from; - if (!e->metric) /* This is metric for external routes. Notice - that I do honour it even if it comes from other protocol than this - rip. That's okay: this way user can set his own value for external + if (!e->metric) /* That's okay: this way user can set his own value for external routes in rip. */ e->metric = 5; e->updated = e->changed = now;