From 3a31c3aad6c53ea9673743f983e13728d8551149 Mon Sep 17 00:00:00 2001 From: Maria Matejka Date: Tue, 7 Sep 2021 16:22:32 +0000 Subject: [PATCH] CLI socket accept() may also fail and should produce some message, not a coredump. --- sysdep/unix/main.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/sysdep/unix/main.c b/sysdep/unix/main.c index 392aff9d..cdf0a310 100644 --- a/sysdep/unix/main.c +++ b/sysdep/unix/main.c @@ -479,6 +479,14 @@ cli_err(sock *s, int err) cli_free(s->data); } +static void +cli_connect_err(sock *s UNUSED, int err) +{ + ASSERT_DIE(err); + if (config->cli_debug) + log(L_INFO "Failed to accept CLI connection: %s", strerror(err)); +} + static int cli_connect(sock *s, uint size UNUSED) { @@ -507,6 +515,7 @@ cli_init_unix(uid_t use_uid, gid_t use_gid) s = cli_sk = sk_new(cli_pool); s->type = SK_UNIX_PASSIVE; s->rx_hook = cli_connect; + s->err_hook = cli_connect_err; s->rbsize = 1024; s->fast_rx = 1;