From f76fe2c0d4847d0e40d8708f97591abf3fa22ea5 Mon Sep 17 00:00:00 2001 From: Romain Vimont Date: Fri, 11 Jun 2021 18:39:23 +0200 Subject: [PATCH] Fix --lock-video-orientation syntax The argument for option --lock-video-orientation has been made optional by 5af9d0ee0faddfca689f468c7d463c86233e8d93. With getopt_long(), contrary to mandatory arguments, optional arguments must be given with a '=': --lock-video-orientation 2 # wrong, parse error --lock-video-orientation=2 # correct --- README.md | 8 ++++---- app/tests/test_cli.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index c3bab060..503ef87d 100644 --- a/README.md +++ b/README.md @@ -215,10 +215,10 @@ To lock the orientation of the mirroring: ```bash scrcpy --lock-video-orientation # initial (current) orientation -scrcpy --lock-video-orientation 0 # natural orientation -scrcpy --lock-video-orientation 1 # 90° counterclockwise -scrcpy --lock-video-orientation 2 # 180° -scrcpy --lock-video-orientation 3 # 90° clockwise +scrcpy --lock-video-orientation=0 # natural orientation +scrcpy --lock-video-orientation=1 # 90° counterclockwise +scrcpy --lock-video-orientation=2 # 180° +scrcpy --lock-video-orientation=3 # 90° clockwise ``` This affects recording orientation. diff --git a/app/tests/test_cli.c b/app/tests/test_cli.c index 3fa9b3d7..94740a9a 100644 --- a/app/tests/test_cli.c +++ b/app/tests/test_cli.c @@ -51,7 +51,7 @@ static void test_options(void) { "--fullscreen", "--max-fps", "30", "--max-size", "1024", - "--lock-video-orientation", "2", + "--lock-video-orientation=2", // optional arguments require '=' // "--no-control" is not compatible with "--turn-screen-off" // "--no-display" is not compatible with "--fulscreen" "--port", "1234:1236",