scrcpy/app/src/server.h

#ifndef SERVER_H
#define SERVER_H

#include "command.h"
#include "net.h"

struct server {
    process_t process;
    socket_t server_socket;
    socket_t device_socket;
    SDL_bool adb_reverse_enabled;
};

#define SERVER_INITIALIZER {          \
    .process = PROCESS_NONE,          \
    .server_socket = INVALID_SOCKET,  \
    .device_socket = INVALID_SOCKET,  \
    .adb_reverse_enabled = SDL_FALSE, \
}

// init default values
void server_init(struct server *server);

// push, enable tunnel et start the server
SDL_bool server_start(struct server *server, const char *serial, Uint16 local_port,
                      Uint16 max_size, Uint32 bit_rate);

// block until the communication with the server is established
socket_t server_connect_to(struct server *server, const char *serial, Uint32 timeout_ms);

// disconnect and kill the server process
void server_stop(struct server *server, const char *serial);

// close and release sockets
void server_destroy(struct server *server);

#endif
Add missing include guards In practice, these headers are included only once, but it's a good practice to always use include guards. 2018-02-08 20:47:31 +08:00			`#ifndef SERVER_H`
			`#define SERVER_H`

Extract server-related functions To lighten screen.c, move start_server() and stop_server() to a separate file. 2018-01-22 18:22:31 +08:00			`#include "command.h"`
Replace SDL_net by custom implementation SDL_net is not very suitable for scrcpy. For example, SDLNet_TCP_Accept() is non-blocking, so we have to wrap it by calling many SDL_Net-specific functions to make it blocking. But above all, SDLNet_TCP_Open() is a server socket only when no IP is provided; otherwise, it's a client socket. Therefore, it is not possible to create a server socket bound to localhost, so it accepts connections from anywhere. This is a problem for scrcpy, because on start, the application listens for nearly 1 second until it accepts the first connection, supposedly from the device. If someone on the local network manages to connect to the server socket first, then they can stream arbitrary H.264 video. This may be troublesome, for example during a public presentation ;-) Provide our own simplified API (net.h) instead, implemented for the different platforms. 2018-02-16 05:59:21 +08:00			`#include "net.h"`
Extract server-related functions To lighten screen.c, move start_server() and stop_server() to a separate file. 2018-01-22 18:22:31 +08:00
Move server-related code to server.c The file server.c already existed, but exposed a low-level API. Make it higher-level, so that scrcpy.c does not handle server details directly. 2018-02-08 22:16:27 +08:00			`struct server {`
			`process_t process;`
Replace SDL_net by custom implementation SDL_net is not very suitable for scrcpy. For example, SDLNet_TCP_Accept() is non-blocking, so we have to wrap it by calling many SDL_Net-specific functions to make it blocking. But above all, SDLNet_TCP_Open() is a server socket only when no IP is provided; otherwise, it's a client socket. Therefore, it is not possible to create a server socket bound to localhost, so it accepts connections from anywhere. This is a problem for scrcpy, because on start, the application listens for nearly 1 second until it accepts the first connection, supposedly from the device. If someone on the local network manages to connect to the server socket first, then they can stream arbitrary H.264 video. This may be troublesome, for example during a public presentation ;-) Provide our own simplified API (net.h) instead, implemented for the different platforms. 2018-02-16 05:59:21 +08:00			`socket_t server_socket;`
			`socket_t device_socket;`
Move server-related code to server.c The file server.c already existed, but exposed a low-level API. Make it higher-level, so that scrcpy.c does not handle server details directly. 2018-02-08 22:16:27 +08:00			`SDL_bool adb_reverse_enabled;`
			`};`
Move server-related functions to server.c In addition to the functions to start/stop the server, move the functions to push the jar and enable/disable the "adb reverse" tunnel. 2018-01-23 22:46:34 +08:00
Move server-related code to server.c The file server.c already existed, but exposed a low-level API. Make it higher-level, so that scrcpy.c does not handle server details directly. 2018-02-08 22:16:27 +08:00			`#define SERVER_INITIALIZER { \`
			`.process = PROCESS_NONE, \`
Replace SDL_net by custom implementation SDL_net is not very suitable for scrcpy. For example, SDLNet_TCP_Accept() is non-blocking, so we have to wrap it by calling many SDL_Net-specific functions to make it blocking. But above all, SDLNet_TCP_Open() is a server socket only when no IP is provided; otherwise, it's a client socket. Therefore, it is not possible to create a server socket bound to localhost, so it accepts connections from anywhere. This is a problem for scrcpy, because on start, the application listens for nearly 1 second until it accepts the first connection, supposedly from the device. If someone on the local network manages to connect to the server socket first, then they can stream arbitrary H.264 video. This may be troublesome, for example during a public presentation ;-) Provide our own simplified API (net.h) instead, implemented for the different platforms. 2018-02-16 05:59:21 +08:00			`.server_socket = INVALID_SOCKET, \`
			`.device_socket = INVALID_SOCKET, \`
Move server-related code to server.c The file server.c already existed, but exposed a low-level API. Make it higher-level, so that scrcpy.c does not handle server details directly. 2018-02-08 22:16:27 +08:00			`.adb_reverse_enabled = SDL_FALSE, \`
			`}`

			`// init default values`
			`void server_init(struct server *server);`

			`// push, enable tunnel et start the server`
			`SDL_bool server_start(struct server server, const char serial, Uint16 local_port,`
			`Uint16 max_size, Uint32 bit_rate);`

			`// block until the communication with the server is established`
Replace SDL_net by custom implementation SDL_net is not very suitable for scrcpy. For example, SDLNet_TCP_Accept() is non-blocking, so we have to wrap it by calling many SDL_Net-specific functions to make it blocking. But above all, SDLNet_TCP_Open() is a server socket only when no IP is provided; otherwise, it's a client socket. Therefore, it is not possible to create a server socket bound to localhost, so it accepts connections from anywhere. This is a problem for scrcpy, because on start, the application listens for nearly 1 second until it accepts the first connection, supposedly from the device. If someone on the local network manages to connect to the server socket first, then they can stream arbitrary H.264 video. This may be troublesome, for example during a public presentation ;-) Provide our own simplified API (net.h) instead, implemented for the different platforms. 2018-02-16 05:59:21 +08:00			`socket_t server_connect_to(struct server server, const char serial, Uint32 timeout_ms);`
Move server-related code to server.c The file server.c already existed, but exposed a low-level API. Make it higher-level, so that scrcpy.c does not handle server details directly. 2018-02-08 22:16:27 +08:00
			`// disconnect and kill the server process`
			`void server_stop(struct server server, const char serial);`
Add missing include guards In practice, these headers are included only once, but it's a good practice to always use include guards. 2018-02-08 20:47:31 +08:00
Do not release TCP sockets while still in use SDLNet_TCP_Close() not only closes, but also release the resources. Therefore, we must not close the socket if another thread attempts to read it. For that purpose, move socket closing from server_stop() to server_destroy(). 2018-02-09 19:59:36 +08:00			`// close and release sockets`
			`void server_destroy(struct server *server);`

Add missing include guards In practice, these headers are included only once, but it's a good practice to always use include guards. 2018-02-08 20:47:31 +08:00			`#endif`